Switching some restate-core types to the new module style #2359
+3,414
−3,890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e migrated to new API
This was referenced Nov 26, 2024
This changes the remaining bits of the API and refactors most of the code to make use of it. What's new: - `TaskCenter` is now simply an zero-size struct with associated functions. - `restate_core::task_center::Handle` provides a way to pass a concrete task-center value around - `restate_core::task_center::OwnedHandle` is mostly unused at the moment, but it's meant to be a future mechanism for auto-drop (guard) task-center ownership. Primarily to be used in main fn.
I really dig this new style to define modules, especially for modules that have significant code/types written in their mod.rs. This makes finding the file much easier. For example, `metadata_store.rs` now has the trait `MetadataStore` instead of `metadata_store/mod.rs`
tillrohrmann
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really dig this new style to define modules, especially for modules that have significant code/types written in their mod.rs. This makes finding the file much easier.
For example,
metadata_store.rsnow has the traitMetadataStoreinstead ofmetadata_store/mod.rsStack created with Sapling. Best reviewed with ReviewStack.