Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review #46

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Code Review #46

merged 2 commits into from
Nov 7, 2024

Conversation

lobis
Copy link
Member

@lobis lobis commented Nov 7, 2024 •
edited by pull-request-badge bot
Loading

lobis Medium: 163 Powered by Pull Request Badge

I did some review. These are the most notable changes:

  • TRestTrack no longer inherits from TObject. There is no need for this as far as I am aware.
  • Imports are formatted according to the style of the other REST-for-Physics libraries.
  • Use std::vector::emplace_back instead of std::vector::push_back in many instances.
  • Fix a few potential bugs where the && operator was incorrectly written as &.
  • Fix a lot of typos (shame on you @DavidDiezIb).

@lobis lobis marked this pull request as ready for review November 7, 2024 10:10
@lobis lobis merged commit cf84a08 into master Nov 7, 2024
64 checks passed
@lobis lobis deleted the lobis-track-review branch November 7, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPorron JPorron JPorron approved these changes

@DavidDiezIb DavidDiezIb Awaiting requested review from DavidDiezIb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lobis @JPorron