This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
Add unit tests #62
Open
Add unit tests #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.gitignore
Outdated
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| .idea |
There was a problem hiding this comment.
Suggested change
| .idea | |
| .idea | |
We should add documentation on our standards for formatting, but I gently suggest we terminate all files with a new line per unix standards
There was a problem hiding this comment.
Thanks for the suggestion but I am going to leave it as it is. The deadline is approaching and we need this merged ASAP.
I left a TODO comment so we can handle this issue on a future PR :)
ashleydavies
approved these changes
Jun 24, 2022
|
LGTM |
caelx
suggested changes
Jun 24, 2022
cbeninati
reviewed
Jun 24, 2022
|
|
||
| test('it should be able to sell high', () => { | ||
| const finalPrice = getBitcoinPriceToday() | ||
| expect(finalPrice).toBeGreaterThan(initialPrice); |
There was a problem hiding this comment.
Suggested change
| expect(finalPrice).toBeGreaterThan(initialPrice); | |
| expect(finalPrice).toBeGreaterThan(initialPrice) |
Consistent terminating characters.
altendky
reviewed
Jun 24, 2022
| yarn-error.log* | ||
| .idea | ||
|
|
||
| TODO: terminate files with new line per unix standard |
There was a problem hiding this comment.
The sensible choice of terms here would be end of line (EOL) given it is intended here to represent the end of a line, not the beginning of an always empty line.
Suggested change
| TODO: terminate files with new line per unix standard | |
| TODO: terminate files with end of line per unix standard |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.