Remove Function$ entirely.

[cristianoc]

Change the AST and compiler back-end so that Function$ is not used anymore to encode function definitions.

[cristianoc]

@mununki are these changes good or bad?

[cristianoc]

Add test to analysis (so it's compiled and uses rescript-react as a dependency) that these compile.
Tested that the same example did not compile on master, so this is the intended transformation that was somehow lost along the way sometime.

de23262

[cristianoc]

@cknitt we can move to testing phase with this.
Eg fix the issue you found.
Once fixed, I have some implementation cleanup left, but would like to add any missing tests first.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite	Current: 7d4af4a	Previous: e1b7fb7	Ratio
Parse RedBlackTree.res - time/run	1.3137930666666666 ms	1.2123143266666667 ms	1.08
Parse Napkinscript.res - time/run	43.116282813333335 ms	39.28006235333333 ms	1.10
Parse HeroGraphic.res - time/run	6.496717546666666 ms	5.13472718 ms	1.27

This comment was automatically generated by workflow using github-action-benchmark.

[cristianoc]

@cknitt all the issues are resolved now, did you test this entirely on one project already?
That's the kind of confirmation needed before moving on with this.

[cknitt]

@cknitt all the issues are resolved now, did you test this entirely on one project already?

Yes, did that before, and now just retested with the last commit. Everything builds fine.

However, I found that the editor tooling crashes:

Error: Command failed: /Users/christoph/.vscode/extensions/chenglou92.rescript-vscode-1.58.0/server/analysis_binaries/darwinarm64/rescript-editor-analysis.exe hover /Users/christoph/projects/cca/inform4/app-common/src/config/ConfigLoader.res 6 16 /var/folders/l3/d1wj17dj2z321tjq9s9fnlsh0000gn/T/rescript_format_file_8986_12 true
    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at checkExecSyncError (node:child_process:925:11)
    at Object.execFileSync (node:child_process:961:15)
    at Object.func (node:electron/js2c/node_init:2:2559)
    at Lt (/Users/christoph/.vscode/extensions/chenglou92.rescript-vscode-1.58.0/server/out/cli.js:36:5456)
    at Ct (/Users/christoph/.vscode/extensions/chenglou92.rescript-vscode-1.58.0/server/out/cli.js:36:5658)
    at aw (/Users/christoph/.vscode/extensions/chenglou92.rescript-vscode-1.58.0/server/out/cli.js:42:5630)
    at process.Ph (/Users/christoph/.vscode/extensions/chenglou92.rescript-vscode-1.58.0/server/out/cli.js:42:15244)
    at process.emit (node:events:518:28) {
  status: null,
  signal: 'SIGSEGV',
  output: [ null, <Buffer >, <Buffer > ],
  pid: 9733,
  stdout: <Buffer >,
  stderr: <Buffer >

[cknitt]

Ok, that seems to be using the analysis exe that comes with the VS Code plugin for some reason.

[cristianoc]

Ok, that seems to be using the analysis exe that comes with the VS Code plugin for some reason.

Great, this PR is ready to go then.
Picking up the right binary is for the TypeScript part for the editor plugin: @zth

[cknitt]

Picking up the right binary is for the TypeScript part for the editor plugin: @zth

This is already (mostly) done, but not merged yet: rescript-lang/rescript-vscode#1055

[cristianoc]

This could be squash merged, but it would mess up rebasing #7195
That's a complex PR: won't take risks of introducing issues while merging. I'll rebase merge this.