Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ocamlformat to 0.26.1 #6493

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Upgrade ocamlformat to 0.26.1 #6493

merged 4 commits into from
Nov 29, 2023

Conversation

aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Nov 25, 2023 •
edited
Loading

Install [email protected] on Windows

@aspeddro aspeddro changed the title Upgrade ocamlformat 0.26.1 Upgrade ocamlformat to 0.26.1 Nov 25, 2023
@aspeddro
Copy link
Contributor Author

@cknitt cont of #6360

@aspeddro
Copy link
Contributor Author

dc1ad98 is a fix for reanalyze warning dead type

cknitt
cknitt approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you were able to resolve the Windows ocamlformat installation issue! 👍

@cristianoc
Copy link
Collaborator

Ready to merge?

@aspeddro
Copy link
Contributor Author

yup

@cristianoc cristianoc merged commit 363257e into rescript-lang:master Nov 29, 2023
14 checks passed
@cknitt cknitt mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aspeddro @cristianoc @cknitt