Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: implicitly opened modules #6446

Merged

Conversation

fhammerschmidt
Copy link
Member

@fhammerschmidt fhammerschmidt commented Oct 20, 2023

This one is a prerequisite for the v11 docs so that we do not need to have open RescriptCore in every example.
See also: rescript-lang/rescript-lang.org#718

@fhammerschmidt
Copy link
Member Author

fhammerschmidt commented Oct 20, 2023

I am not sure if the api version change is necessary btw. Maybe it can still be v3 since we are at the experimental stage for 11 still?

cc @ryyppy

@zth
Copy link
Collaborator

zth commented Oct 21, 2023

This looks good to me! What does the API version number do?

@cknitt
Copy link
Member

cknitt commented Oct 22, 2023

Looks good to me, too! 👍 Could you rebase and add a CHANGELOG entry?

@fhammerschmidt
Copy link
Member Author

This looks good to me! What does the API version number do?

I think it's just to make it easier for the playground to decide which features/libraries can be used. https://github.com/rescript-association/rescript-lang.org/blob/master/src/common/CompilerManagerHook.res

@fhammerschmidt fhammerschmidt force-pushed the playground_implicitly_open_modules branch from ce56d3b to f16f4f8 Compare October 22, 2023 08:09
CHANGELOG.md Outdated Show resolved Hide resolved
@fhammerschmidt fhammerschmidt force-pushed the playground_implicitly_open_modules branch from f16f4f8 to a68d8bf Compare October 22, 2023 10:15
@ryyppy
Copy link
Member

ryyppy commented Oct 23, 2023

This looks good to me! What does the API version number do?

I think it's just to make it easier for the playground to decide which features/libraries can be used. https://github.com/rescript-association/rescript-lang.org/blob/master/src/common/CompilerManagerHook.res

The apiVersion number should always be raised whenever the API has received some feature addition or breaking change. As you already stated correctly, the CompilerManagerHook differentiates between different versions to gracefully support all compiler bundles.

@fhammerschmidt fhammerschmidt force-pushed the playground_implicitly_open_modules branch from a68d8bf to 377687e Compare October 23, 2023 09:16
@fhammerschmidt
Copy link
Member Author

Then I guess this PR is ready to merge as-is!

@zth zth merged commit c8cfd63 into rescript-lang:master Oct 23, 2023
7 checks passed
@fhammerschmidt fhammerschmidt deleted the playground_implicitly_open_modules branch October 23, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants