-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground: implicitly opened modules #6446
Playground: implicitly opened modules #6446
Conversation
I am not sure if the api version change is necessary btw. Maybe it can still be v3 since we are at the experimental stage for 11 still? cc @ryyppy |
This looks good to me! What does the API version number do? |
Looks good to me, too! 👍 Could you rebase and add a CHANGELOG entry? |
I think it's just to make it easier for the playground to decide which features/libraries can be used. https://github.com/rescript-association/rescript-lang.org/blob/master/src/common/CompilerManagerHook.res |
ce56d3b
to
f16f4f8
Compare
f16f4f8
to
a68d8bf
Compare
The apiVersion number should always be raised whenever the API has received some feature addition or breaking change. As you already stated correctly, the CompilerManagerHook differentiates between different versions to gracefully support all compiler bundles. |
a68d8bf
to
377687e
Compare
Then I guess this PR is ready to merge as-is! |
This one is a prerequisite for the v11 docs so that we do not need to have
open RescriptCore
in every example.See also: rescript-lang/rescript-lang.org#718