Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Node.js v16 (EoL) support #6429

Merged
merged 2 commits into from
Feb 27, 2024
Merged

drop Node.js v16 (EoL) support #6429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e605d4c
drop Node.js v16 (EoL) support
cometkim Oct 10, 2023
a076692
add CHANGELOG
cometkim Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18

- name: Copy exes to platform bin dirs
run: node ./scripts/copyExes.js
Expand Down Expand Up @@ -169,7 +169,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18

- name: Install npm packages
run: npm ci --ignore-scripts
Expand Down Expand Up @@ -279,7 +279,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18

- name: NPM install
run: npm ci --ignore-scripts
Expand Down Expand Up @@ -340,7 +340,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18

- name: Download artifacts
uses: actions/download-artifact@v4
Expand Down Expand Up @@ -372,7 +372,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
registry-url: https://registry.npmjs.org # Needed to make auth work for publishing

- name: Download artifacts
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- `lazy` syntax is no longer supported. If you're using it, use `Lazy` module or `React.lazy_` instead. https://github.com/rescript-lang/rescript-compiler/pull/6342
- Remove handling of attributes with `bs.` prefix (`@bs.as` -> `@as` etc.). https://github.com/rescript-lang/rescript-compiler/pull/6643
- Remove obsolete `@bs.open` feature. https://github.com/rescript-lang/rescript-compiler/pull/6629
- Drop Node.js version <18 support, due to it reaching End-of-Life. https://github.com/rescript-lang/rescript-compiler/pull/6429

#### :house: Internal

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Happy hacking!

> Most of our contributors are working on Apple machines, so all our instructions are currently macOS / Linux centric. Contributions for Windows development welcome!

- [NodeJS v16](https://nodejs.org/)
- [NodeJS v18](https://nodejs.org/)
- C compiler toolchain (usually installed with `xcode` on Mac)
- `opam` (OCaml Package Manager)
- VSCode (+ [OCaml Platform Extension](https://marketplace.visualstudio.com/items?itemName=ocamllabs.ocaml-platform))
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"prettier": "2.7.1"
},
"engines": {
"node": ">=10"
"node": ">=18"
},
"bin": {
"bsc": "bsc",
Expand Down