Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when concatenating strings #6416

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Improve error message when concatenating strings #6416

merged 2 commits into from
Sep 28, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Sep 27, 2023

cc @DZakh

@zth zth requested a review from cristianoc September 27, 2023 19:53
cristianoc
cristianoc approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch.
That gets lots of people confused.

@zth zth merged commit c799ba1 into master Sep 28, 2023
14 checks passed
@zth zth deleted the error-message-string-concatenation branch September 28, 2023 04:41
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 2, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc