Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages: Improve "Somewhere wanted" messages #6410

Merged
merged 14 commits into from
Sep 26, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Sep 20, 2023

This PR improves the "Somewhere wanted" error messages by adding more context as appropriate. All feedback welcome.

@zth zth marked this pull request as ready for review September 24, 2023 18:23
@zth zth requested a review from cristianoc September 24, 2023 18:23
@zth
Copy link
Collaborator Author

zth commented Sep 24, 2023

@cristianoc might tweak one or two error messages, but the approach is ready for review.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing.
The only question is whether there are ways to trigger these errors that are different from what's in the tests.
Eg when calling foo(x) and finding an inconsistency, sometimes one blames X and sometimes foo.
That's it, just a vague abstract question.
In any case, this is a significant improvement no matter what and if there are unexpected ways to trigger these errors, they will come up with use.

@zth
Copy link
Collaborator Author

zth commented Sep 26, 2023

This is amazing. The only question is whether there are ways to trigger these errors that are different from what's in the tests. Eg when calling foo(x) and finding an inconsistency, sometimes one blames X and sometimes foo. That's it, just a vague abstract question. In any case, this is a significant improvement no matter what and if there are unexpected ways to trigger these errors, they will come up with use.

Yeah I agree, and didn't move forward with a few improvements just because they triggered in the wrong places. But I guess the best way forward is to let this loose and just fix things as they appear.

@zth zth merged commit 6f972d7 into master Sep 26, 2023
14 checks passed
@zth zth deleted the improve-somewhere-wanted branch September 26, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants