-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error messages: Improve "Somewhere wanted" messages #6410
Conversation
@cristianoc might tweak one or two error messages, but the approach is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing.
The only question is whether there are ways to trigger these errors that are different from what's in the tests.
Eg when calling foo(x) and finding an inconsistency, sometimes one blames X and sometimes foo.
That's it, just a vague abstract question.
In any case, this is a significant improvement no matter what and if there are unexpected ways to trigger these errors, they will come up with use.
Yeah I agree, and didn't move forward with a few improvements just because they triggered in the wrong places. But I guess the best way forward is to let this loose and just fix things as they appear. |
This PR improves the "Somewhere wanted" error messages by adding more context as appropriate. All feedback welcome.