Try making top level unit error message clearer #6407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspeddro
reviewed
Sep 19, 2023
jscomp/build_tests/super_errors/expected/partial_app.res.expected
Outdated
Show resolved
Hide resolved
tsnobip
approved these changes
Sep 19, 2023
🙏 Are there more scenarios where we should customize this error message depending on what the actual expression is? I couldn't think of any that doesn't also fit well as just a generic message. Function calls seems to be the main gotcha here, because that's probably what you're doing most of the time as you're getting this message. |
|
Clear msg! 👍 |
cknitt
reviewed
Sep 19, 2023
| | Bs_toplevel_expression_unit -> | ||
| "Toplevel expression is expected to have unit type." | ||
| | Bs_toplevel_expression_unit help -> | ||
| Printf.sprintf "This%sis at the top level and is expected to return `unit`. But, it's returning %s.\n\n In ReScript, anything at the top level must evaluate to `unit`. You can fix this by assigning the expression to a value, or piping it into the `ignore` function.%s" |
There was a problem hiding this comment.
Sorry for reviewing so late 😞 and for nit-picking, but I think there should be no comma after "But".
There was a problem hiding this comment.
PRs welcome for late reviewers 😏
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.