Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gRPC log sink #8709

Merged
merged 13 commits into from
Jan 22, 2025
Merged

Implement gRPC log sink #8709

merged 13 commits into from
Jan 22, 2025

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Jan 16, 2025

Related

What

This PR adds the ability to stream logs to an in-memory storage node.

It is exposed via GrpcSink and connect_grpc in the Python SDK.

  • Python SDK
  • C++
  • Rust

@jprochazk jprochazk added include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages remote-store remote store gRPC API labels Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Web viewer failed to build.

Result Commit Link Manifest
https://rerun.io/viewer/pr/8709 +nightly +main

Note: This comment is updated whenever you push a commit.

@jprochazk jprochazk changed the title Implement gRPC sink Implement gRPC log sink Jan 19, 2025
@jprochazk jprochazk marked this pull request as ready for review January 19, 2025 17:14
@emilk emilk self-requested a review January 21, 2025 11:16
@jprochazk jprochazk merged commit 03f758c into main Jan 22, 2025
10 of 16 checks passed
@jprochazk jprochazk deleted the jan/grpc-log-sink branch January 22, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages remote-store remote store gRPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement log sink for in-memory gRPC server
2 participants