Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use insta for dataframe snapshot tests #8696

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 15, 2025

This will make it easier to switch out TransportChunk for RecordBatch

@emilk emilk added 🏹 arrow concerning arrow 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
2a12468 https://rerun.io/viewer/pr/8696 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk merged commit ec07b14 into main Jan 15, 2025
31 checks passed
@emilk emilk deleted the emilk/insta-dataframe-tests branch January 15, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant