Update GraphEdge visualizer to use sliced struct fields
#8555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
teh-cmc
commented
Dec 20, 2024
•
teh-cmc
commented
- DNM: requires Update all visualizers to use new Chunk iteration APIs #8554
teh-cmc
added
📺 re_viewer
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
teh-cmc
commented
Dec 20, 2024
Comment on lines
51
to
58
| // TODO(cmc): could we (improve and then) use reflection for this? | ||
| re_types::static_assert_struct_has_fields!( | ||
| datatypes::Utf8Pair, | ||
| first: datatypes::Utf8, | ||
| second: datatypes::Utf8, | ||
| ); | ||
| let source: ArchetypeFieldName = "first".into(); | ||
| let target: ArchetypeFieldName = "second".into(); |
There was a problem hiding this comment.
There are a million possible ways to "improve" this. Whether it's via reflection, or codegen, or whatever else.
For now, I very much like the fact that this is so dumb and so low-tech.
We can make it more complex/automated when the need arises.
There was a problem hiding this comment.
I need to get rid of the ArchetypeFieldName though, that's not needed anymore.
teh-cmc
force-pushed
the
cmc/sliced_visualizers
branch
from
92a0bce to
7bb905f
Compare
teh-cmc
force-pushed
the
cmc/graphedge_struct_slice
branch
from
a757399 to
edfc60d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.