Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short circuit graph simulation if all nodes are fixed #8549

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Dec 19, 2024

What

Title.

Wonder if we should even show the forces section in the selection panel in this case—but that might be confusing for the user too.

@grtlr grtlr added ui concerns graphical user interface 🚀 performance Optimization, memory use, etc include in changelog labels Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
cc022e0 https://rerun.io/viewer/pr/8549 +nightly +main

Note: This comment is updated whenever you push a commit.

Base automatically changed from grtlr/graph-nodes-as-label to main December 20, 2024 08:22
@teh-cmc teh-cmc self-requested a review December 20, 2024 08:42
crates/viewer/re_view_graph/src/layout/provider.rs Outdated Show resolved Hide resolved
crates/viewer/re_view_graph/src/layout/provider.rs Outdated Show resolved Hide resolved
crates/viewer/re_view_graph/src/layout/provider.rs Outdated Show resolved Hide resolved
crates/viewer/re_view_graph/src/layout/provider.rs Outdated Show resolved Hide resolved
@grtlr grtlr requested a review from teh-cmc December 20, 2024 12:35
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@grtlr grtlr merged commit 19e93a6 into main Dec 20, 2024
31 checks passed
@grtlr grtlr deleted the grtlr/short-circuit-layout branch December 20, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🚀 performance Optimization, memory use, etc ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants