Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undo not working in some entity drag-and-drop instances #8526

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Dec 18, 2024

This is a band-aid patch to address an issue with entity path filter which would result in the following behaviours:

  • the entity path filter would be perma-writen to the blueprint store when the view is selected (in some cases)
  • in such cases, this would break undo on user change (aka with entity drag-and-drop)

The core issue is deeper and might cause panics with rust 1.81+. The TL;DR is that the current EntityPathFilter type is ambiguous as to whether its content has substitutions (aka $origin) applied or not. In particular Eq and Ord apply to unsubstituted, resp. substituted content (which can lead to the above panic). This should be further cleaned by having two structures, one unsubstituted and another substituted.

@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

Web viewer failed to build.

| Result | Commit | Link | Manifest |
| ------ | ------- | ----- |
| ❌ | | https://rerun.io/viewer/pr/8526 | +nightly +main |

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc merged commit 9d38189 into main Dec 18, 2024
26 checks passed
@teh-cmc teh-cmc deleted the antoine/fix-dnd-undo branch December 18, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants