Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-entity drag-and-drop only adding one entity #8519

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Dec 17, 2024

Related

What

Fix a bug in #8431 where multi-entity drag-and-drop would only add a single entity due to a foot-gun in our entity path filter mutation API (see #8518 for more). Also add a new checklist.

@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

Web viewer failed to build.

| Result | Commit | Link | Manifest |
| ------ | ------- | ----- |
| ❌ | | https://rerun.io/viewer/pr/8519 | +nightly +main |

Note: This comment is updated whenever you push a commit.

crates/viewer/re_viewport/src/viewport_ui.rs Outdated Show resolved Hide resolved
@abey79 abey79 merged commit ed05c75 into main Dec 18, 2024
27 checks passed
@abey79 abey79 deleted the antoine/fix-multi-entities branch December 18, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants