Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the event count in the static-over-temporal error message #8513

Merged
merged 1 commit into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/store/re_chunk_store/src/stats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -320,4 +320,24 @@ impl ChunkStore {
.sum()
})
}

/// Returns the number of temporal events logged for an entity for a specific component on all timelines.
///
/// This ignores static events.
pub fn num_temporal_events_for_component_on_all_timelines(
&self,
entity_path: &EntityPath,
component_name: ComponentName,
) -> u64 {
self.all_timelines()
.iter()
.map(|timeline| {
self.num_temporal_events_for_component_on_timeline(
timeline,
entity_path,
component_name,
)
})
.sum()
}
}
3 changes: 1 addition & 2 deletions crates/viewer/re_data_ui/src/component.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ impl DataUi for ComponentPathLatestAtResults<'_> {

let temporal_message_count = engine
.store()
.num_temporal_events_for_component_on_timeline(
&query.timeline(),
.num_temporal_events_for_component_on_all_timelines(
entity_path,
*component_name,
);
Expand Down
Loading