Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for scrolling content to our modals #8492

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Dec 16, 2024

What

This PR builds proper scrollability to our modals, thereby fixing:

  • an ugly glitch with large add/remove entity modal
  • add view/container modal not scrollable with very small viewer window size

Before

image

After

image image

@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

Web viewer failed to build.

| Result | Commit | Link | Manifest |
| ------ | ------- | ----- |
| ❌ | | https://rerun.io/viewer/pr/8492 | +nightly +main |

Note: This comment is updated whenever you push a commit.

@teh-cmc
Copy link
Member

teh-cmc commented Dec 17, 2024

Can we add a checklist for modals? Even something extremely barebones ("click on add container and make sure it's not insane"), so the release manager are reminded to check them.

@teh-cmc teh-cmc self-requested a review December 17, 2024 08:31
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the code, but it works.

See my comment above: add a checklist please.

crates/viewer/re_ui/src/modal.rs Outdated Show resolved Hide resolved
@teh-cmc teh-cmc merged commit d41c53f into main Dec 17, 2024
27 checks passed
@teh-cmc teh-cmc deleted the antoine/better-scroll-modals branch December 17, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants