Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest egui #8469

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Update to latest egui #8469

merged 1 commit into from
Dec 16, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 16, 2024

Related

@emilk emilk added 📺 re_viewer affects re_viewer itself dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md egui Requires egui/eframe work labels Dec 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ ec0e404 https://rerun.io/viewer/pr/8469 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk merged commit b68b4e9 into main Dec 16, 2024
35 checks passed
@emilk emilk deleted the emilk/update-to-egui-once-more branch December 16, 2024 08:51
@grtlr grtlr mentioned this pull request Dec 16, 2024
Merged
teh-cmc pushed a commit that referenced this pull request Dec 16, 2024
@grtlr
Fix single-click and double-click in the graph view (#8474)
40338bd 
### Related

<!--
Include links to any related issues/PRs in a bulleted list, for example:
* Closes #1234
* Part of #1337
-->

* Closes #8437
* Closes #8442

### What

This implements:
* Single-click on empty space to select view.
* Double-click on node to select entire entity.

Merging @emilk's recent changes (#8469 and #8457) seems to have fixed
the flickering on selection too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc egui Requires egui/eframe work exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @abey79