Migration kernel for the blueprint space-view-related breaking changes #8439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
enhancement
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12300216701 |
Wumpf
approved these changes
Dec 12, 2024
Comment on lines
64
to
68
| if self.id.kind == re_log_types::StoreKind::Blueprint { | ||
| chunk = Arc::new(chunk.clone_as_untagged()); | ||
| let patched = chunk.patched_for_blueprint_021_compat(); | ||
| let patched = patched.clone_as_untagged(); | ||
| chunk = Arc::new(patched); | ||
| } |
There was a problem hiding this comment.
I wish we had a version tag on the store so we're not applying this indefinitely into the future ...
There was a problem hiding this comment.
Yeah we need to pull the StoreInfos all the way in at some point. We can do that later though, that's fine (I don't expect this particular change to be particularly version specific -- SpaceView is not making a come back anytime soon I hope 😛).
grtlr
pushed a commit
that referenced
this pull request
Dec 13, 2024
#8439) Our first migration kernel! This makes it possible to load <0.21 blueprints into Rerun 0.21, transparently, without user intervention. More importantly, this marks the first step in exploring these kinds of tools, as part of our general promise of becoming more and more stable over time. Basically a gloried search and replace. To test it, save any blueprint from 0.20 (https://app.rerun.io/version/0.20.3/index.html), and load it into 0.21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our first migration kernel! This makes it possible to load <0.21 blueprints into Rerun 0.21, transparently, without user intervention.
More importantly, this marks the first step in exploring these kinds of tools, as part of our general promise of becoming more and more stable over time.
Basically a gloried search and replace.
To test it, save any blueprint from 0.20 (https://app.rerun.io/version/0.20.3/index.html), and load it into 0.21.