Factor out NearClipPlane from VisualBounds2D
#8433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grtlr
added
the
exclude from changelog
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
Wumpf
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
looking good!
It looks like we never had a fallback provider for NearClipPlane. @Wumpf can you please confirm that this is correct? 🙏
yup. In absence of a fallback provider, the fallback is determined by the "placeholder". The placeholder in turn is registered as part of the generated component reflection to be the Default::default if available. If this isn't present either, we generate a null arrow array. 😵
Wumpf
reviewed
Dec 12, 2024
crates/store/re_types/definitions/rerun/blueprint/archetypes/near_clip_plane.fbs
Show resolved
Hide resolved
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
NearClipRangefromVisualBounds2d#8415What
Title.
It looks like we never had a fallback provider for
NearClipPlane. @Wumpf can you please confirm that this is correct? 🙏