-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement complete Graph View example #8421
Conversation
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
e328ff1
to
bd71bf0
Compare
15e18a3
to
c267ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, works great.
Gotta figure out which examples stay and which ones go, and update the manifest accordingly.
If a Rust example stay, then please keep the Python counterpart too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always suspicious when a check gets removed 😬. What's the reasoning here? (Reminder: people don't regularly go through all the examples; they do go through the entire checklist though).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one check used to be a special case for the graph view back when we didn't have the physics simulation fully set up.
Now that we have this that check it evolved into the full-featured example. The remaining graph check covers the more weird edge cases.
Co-authored-by: Clement Rey <[email protected]>
What
This PR tries to create a more convincing example for the graph view.
It consists of 4 views:
There are still some minor things to fix: