Enrich ReDap Catalog with RecordingUri on the fly #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zehiko
added
remote-store
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
jleibs
approved these changes
Dec 11, 2024
| @@ -273,7 +279,7 @@ async fn stream_catalog_async( | |||
| let store_id = StoreId::from_string(StoreKind::Recording, "catalog".to_owned()); | |||
|
|
|||
| let store_info = StoreInfo { | |||
| application_id: ApplicationId::from("rerun_data_platform"), | |||
| application_id: ApplicationId::from("redap_catalog"), | |||
There was a problem hiding this comment.
I came here to request that you make this same change -- you must have hit the same issue as me.
There was a problem hiding this comment.
yeah, same app id -> same blueprint :) Hopefully we soon get that sorted with GetStoreInfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As of right now, only the viewer is fully aware of Data Platform's endpoint, so we leverage that to enrich Catalog view with
RecordingUrifor each recording.Testing done