Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make our collapsing triangle thinner for more consistency with our icons #8408

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Make our collapsing triangle thinner for more consistency with our icons #8408

merged 5 commits into from
Dec 12, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Dec 11, 2024 •
edited
Loading

Related

What

todo:

  •  handle the pesky triangles of the add/remove entity modal.
  • update main when unbroken and make sure the add/remove modal is not broken

Before:

image

After:

image

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Dec 11, 2024
@abey79 abey79 requested a review from gavrelina December 11, 2024 10:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited by abey79
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ c4cc379 https://rerun.io/viewer/pr/8408 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 marked this pull request as draft December 11, 2024 10:32
@abey79 abey79 marked this pull request as ready for review December 11, 2024 11:13
gavrelina
gavrelina approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@gavrelina gavrelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@abey79 abey79 merged commit 32181b4 into main Dec 12, 2024
31 of 32 checks passed
@abey79 abey79 deleted the antoine/light-arrows branch December 12, 2024 09:56
abey79 added a commit that referenced this pull request Dec 12, 2024
@abey79
Update test snapshots invalidated by #8408
758435a
@abey79 abey79 mentioned this pull request Dec 12, 2024
Merged
Wumpf pushed a commit that referenced this pull request Dec 12, 2024
@abey79
Update test snapshots invalidated by #8408 (#8434)
bee0f81
@abey79 abey79 mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavrelina gavrelina gavrelina approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change icons for the hierarchy tree chevron from closed shape to open shape
2 participants
@abey79 @gavrelina