Refactor design tokens to use a proper color table #8322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
ui
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
commented
Dec 5, 2024
|
|
||
| impl ColorToken { | ||
| #[inline] | ||
| pub fn new(hue: Hue, shade: Shade) -> Self { |
There was a problem hiding this comment.
With enumn (which we already depend on) I could easy add support for u16 input, but then we must deal with error management. For that, we could either:
- panic
- have an invalid state for
ColorToken(e.g.shade = None), which would return a random color when queried (so it flashes in the UI) and logs an error
# Conflicts: # crates/viewer/re_ui/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
This PR refactors the design token as follows:
design_tokens.jsonare now loaded in a big table at startup.ColorToken, which is basically an index into this table.design_token.rsfile is the de facto source of truth of semantic aliasing for colors.