Numpy 2.0 allowed in pyproject.toml #8306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
abey79
added
dependencies
abey79
reviewed
Dec 4, 2024
| @@ -14,7 +14,7 @@ classifiers = [ | |||
| dependencies = [ | |||
| # Must match list in `.github/workflows/reusable_test_wheels.yml` | |||
| "attrs>=23.1.0", | |||
| "numpy>=1.23,<2", | |||
| "numpy>=1.23", | |||
There was a problem hiding this comment.
This invalidates the pixi.lock file, which explains the CI failure. Could you run any pixi command (e.g. pixi run rerun) to update the lock file and push it?
|
@rerun-bot approve |
|
It looks like you are using a pixi version that is newer than the one we currently have in CI. I'll check if we can migrate to the new version to make this PR mergeable. |
|
Can I update my branch? |
Yes, should be good now. |
|
C++ CI failed : The error in the logs is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
A very small commit to see if CI still pass with Numpy 2.0 and over allowed, as python projects are moving quickly to it.