Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build - run cargo metadata with --offline & --no-deps #8168

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 18, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

To deploy documentation changes immediately after merging this PR, add the deploy docs label.

@Wumpf Wumpf added 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation 🦀 Rust API Rust logging API include in changelog labels Nov 18, 2024
crates/build/re_build_tools/src/lib.rs Outdated Show resolved Hide resolved
@teh-cmc teh-cmc added the do-not-merge Do not merge this PR label Nov 18, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Nov 18, 2024

Let's see how that goes before merging anything: https://github.com/rerun-io/rerun/actions/runs/11897219343

@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Nov 19, 2024
@Wumpf Wumpf merged commit 91a07f5 into main Nov 19, 2024
88 of 92 checks passed
@Wumpf Wumpf deleted the andreas/fix-rust-docs branch November 19, 2024 08:06
@Wumpf
Copy link
Member Author

Wumpf commented Nov 19, 2024

didn't go so well, we need another fix for this, doing this off main

emilk pushed a commit that referenced this pull request Nov 20, 2024
…8168)

### What

* solves #8165
(don't close ticket yet, have to confirm that docs.rs actually works)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8168?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8168?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/8168)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.

---------

Co-authored-by: Clement Rey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants