Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to log custom components using rr.send_columns #8163

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 15, 2024

What

This PR primarily overhauls rr.AnyBatchValue(), a wrapper around pyarrow to package any data to what looks like a serialised custom component:

  • It publicly expose it, including in the python reference documentation.¨
  • It makes it compatible with send_columns.
  • It add the .partition() method.

Also in this PR:

  • Makes rr.AnyValues() compatible with send_columns (you need to call values.as_component_batch() though)
  • Add a documentation section to explain all of the above, with a couple of snippets

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

To deploy documentation changes immediately after merging this PR, add the deploy docs label.

@abey79 abey79 added 🐍 Python API Python logging API include in changelog enhancement New feature or request labels Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Latest documentation preview deployed successfully.

Result Commit Link
51571ce https://landing-poek9jfsi-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@abey79 abey79 marked this pull request as ready for review November 15, 2024 16:18
@abey79
Copy link
Member Author

abey79 commented Nov 15, 2024

@rerun-bot full-check

Copy link

@abey79 abey79 mentioned this pull request Nov 21, 2024
5 tasks
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@abey79 abey79 merged commit 8992f8f into main Nov 22, 2024
71 of 72 checks passed
@abey79 abey79 deleted the antoine/anyvalue-send-column branch November 22, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants