Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last remaining C++ warnings #8160

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Fix last remaining C++ warnings #8160

merged 4 commits into from
Nov 15, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 15, 2024

This fixes the last two remaining warnings I get when pixi run cpp-build-all.


  • 🦭

@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 😤 annoying Something in the UI / SDK is annoying to use 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Nov 15, 2024
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with nits

tests/cpp/plot_dashboard_stress/main.cpp Outdated Show resolved Hide resolved
@teh-cmc teh-cmc merged commit 2e561c5 into main Nov 15, 2024
38 checks passed
@teh-cmc teh-cmc deleted the cmc/missed_one_switch branch November 15, 2024 14:03
emilk pushed a commit that referenced this pull request Nov 20, 2024
This fixes the last two remaining warnings I get when `pixi run
cpp-build-all`.

* One of them is just a switch I forgot in
#8057.
* The other is just GCC being weird... I dunno man.

---------

Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🌊 C++ API C/C++ API specific 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants