Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember the last center position in the map view #8120

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 13, 2024

What

When ever we compute a center position from the data, we keep it around in the view state such that we can use it should the data suddenly disappear (aka. time cursor to before data was born, or empty range visible history).

Part of:

map_remember_center_position.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

To deploy documentation changes immediately after merging this PR, add the deploy docs label.

@abey79 abey79 added feat-map-view Everything related to the map view exclude from changelog PRs with this won't show up in CHANGELOG.md 🪳 bug Something isn't working labels Nov 13, 2024
@Wumpf Wumpf self-requested a review November 13, 2024 14:09
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delightful!

@Wumpf Wumpf merged commit 7841b5e into main Nov 13, 2024
46 of 48 checks passed
@Wumpf Wumpf deleted the antoine/map-remember-position branch November 13, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants