Fix issues with seeking in some H.264 videos on native & web #8111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
force-pushed
the
andreas/mp4-update
branch
from
262c5ec to
a8fe2d2
Compare
|
Tested the "oscilloscope video" on Web: Works but Firefox still struggles with bframe stepping (there's a separate issue about this), fine in Chrome though (wasn't before!) |
emilk
approved these changes
Nov 13, 2024
| @@ -75,6 +75,24 @@ impl VideoData { | |||
| } | |||
| } | |||
|
|
|||
| // Generate data for `test_latest_sample_index_at_presentation_timestamp` test. | |||
| // re_log::info!( | |||
There was a problem hiding this comment.
If you use if false { instead the code won't code-rot
| @@ -113,7 +113,9 @@ fn video_data_ui(ui: &mut egui::Ui, ui_layout: UiLayout, video_data: &VideoData) | |||
| .value_text(video_data.gops.len().to_string()), | |||
| ) | |||
| .on_hover_text("The total number of Group of Pictures (GOPs) in the video."); | |||
| samples_statistics_ui(ui, &video_data.samples_statistics); | |||
| ui.list_item_flat_noninteractive( | |||
| PropertyContent::new("All PTS equal DTS").value_bool(video_data.samples_statistics.dts_always_equal_pts) | |||
There was a problem hiding this comment.
It would be nice to destruct samples_statistics here so that if we add new fields to it, we remember to also add a UI for it
6 tasks
emilk
pushed a commit
that referenced
this pull request
Nov 13, 2024
#8117) ### What * part of #8073 Tested on top of #8111 in Chrome @ Windows with a video that would previously not show the last two frames.  ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8117?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/8117?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/8117) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates re_mp4 to 0.3.0, details of fixes see https://github.com/rerun-io/re_mp4/releases/tag/0.3.0
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.