Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listing of enabled features in rerun --version #8095

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 12, 2024

What

RERUN_IS_PUBLISHING was incorrectly set when we weren't publishing crates.
This lead to a rerun --version not showing the correct feature flags in our release.
This should fix it.
I'll make an alpha-release once merged to verify.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ⛴ release Related to shipping or publishing include in changelog labels Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Latest documentation preview deployed successfully.

Result Commit Link
03aaaeb https://landing-5795gga9z-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@emilk emilk merged commit baba6a5 into main Nov 12, 2024
46 checks passed
@emilk emilk deleted the emilk/fix-feature-flags branch November 12, 2024 11:19
@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md and removed include in changelog labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant