Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make old ffmpeg version a hard error #8094

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 12, 2024

What

... and make ffmpeg version parsing more robust

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Nov 12, 2024
@Wumpf Wumpf force-pushed the andreas/hard-min-ffmpeg-version branch from 893c887 to 10ab7e6 Compare November 12, 2024 13:59
@Wumpf Wumpf marked this pull request as ready for review November 12, 2024 14:18
@Wumpf Wumpf force-pushed the andreas/hard-min-ffmpeg-version branch from e312c25 to 29c939c Compare November 12, 2024 14:53
@Wumpf Wumpf force-pushed the andreas/hard-min-ffmpeg-version branch from 29c939c to 55e5aa3 Compare November 12, 2024 14:55
@abey79 abey79 self-requested a review November 12, 2024 14:55
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Wumpf Wumpf merged commit 93b611e into main Nov 12, 2024
36 checks passed
@Wumpf Wumpf deleted the andreas/hard-min-ffmpeg-version branch November 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants