Fix a bunch of broken feature flags #8021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🪳 bug
teh-cmc
commented
Nov 6, 2024
| @@ -0,0 +1,3 @@ | |||
| fn main() { | |||
| println!("cargo::rustc-check-cfg=cfg(disable_web_viewer_server)"); | |||
There was a problem hiding this comment.
Won't do anything for now, but once we bump to Rust 1.80+ this will tell the checker that this flag actually exists for realsies.
abey79
approved these changes
Nov 7, 2024
Comment on lines
-362
to
-364
|
|
||
| #[cfg(target_arch = "wasm32 ")] | ||
| Self::ViewportMode(_) => None, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered them by temporarily upgrading to Rust 1.80, which landed the feature flag checker.