Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming of gRPC-related crates and URIs #8016

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Better naming of gRPC-related crates and URIs #8016

merged 8 commits into from
Nov 6, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 6, 2024

What

  • A Rerun Data Platform gRPC url now has the rerun:// schema
  • The gRPC protobuf types are defined in re_protos
  • The builder of the types is called re_protos_builder
  • The gRPC client is in re_grpc_client
  • The feature-flag is called grpc

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md dataplatform Rerun Data Platform integration labels Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Deployed docs

Commit Link
399dcca https://landing-hoq3bmc11-rerun.vercel.app/docs

@emilk
Copy link
Member Author

emilk commented Nov 6, 2024

After talking to @zehiko, we've decided to further rename re_grpc_types to re_protos

@emilk emilk marked this pull request as draft November 6, 2024 14:21
@emilk emilk marked this pull request as ready for review November 6, 2024 14:41
@emilk emilk merged commit cf342b8 into main Nov 6, 2024
43 checks passed
@emilk emilk deleted the emilk/rerun-url branch November 6, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataplatform Rerun Data Platform integration exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants