Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MapProvider variant when not available #8006

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 5, 2024

What

This PR introduces a possibly over-engineered generic mechanism to control the availability of individual view property variant, and uses it to disable mapbox-based map background when the API key isn't properly set.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added feat-map-view Everything related to the map view exclude from changelog PRs with this won't show up in CHANGELOG.md do-not-merge Do not merge this PR labels Nov 5, 2024
@Wumpf Wumpf self-requested a review November 5, 2024 19:17
Base automatically changed from antoine/settings-screen to main November 6, 2024 08:09
@abey79 abey79 force-pushed the antoine/disable-mapbox-map-provider branch from 26067f9 to a92c420 Compare November 6, 2024 08:11
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see why you called this overengineered. The fact that I actually like it a lot might be quite telling about the state of things here 😅

crates/viewer/re_component_ui/src/lib.rs Outdated Show resolved Hide resolved
@abey79 abey79 removed the do-not-merge Do not merge this PR label Nov 6, 2024
@abey79 abey79 merged commit 3a32772 into main Nov 6, 2024
42 checks passed
@abey79 abey79 deleted the antoine/disable-mapbox-map-provider branch November 6, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants