Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote store registration API only registers a single recording #7982

Merged
merged 5 commits into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,17 @@ service StorageNode {
rpc Query(QueryRequest) returns (stream QueryResponse) {}
rpc FetchRecording(FetchRecordingRequest) returns (stream FetchRecordingResponse) {}
rpc GetRecordingMetadata(GetRecordingMetadataRequest) returns (GetRecordingMetadataResponse) {}
// TODO(zehiko) - should this be singular recording registration? Currently we can have 1 rrd => many recordings
rpc RegisterRecordings(RegisterRecordingsRequest) returns (RegisterRecordingsResponse) {}
rpc RegisterRecording(RegisterRecordingRequest) returns (RegisterRecordingResponse) {}
}

// ---------------- RegisterRecording ------------------

message RegisterRecordingsRequest {
message RegisterRecordingRequest {
// human readable description of the recording
string description = 1;
// information about recording's backing storage
// TODO(zehiko) add separate info about the "source" recording
ObjectStorage obj_storage = 2;
string url = 2;
// type of recording
RecordingType typ = 3;
// (optional) any additional metadata that should be associated with the recording
Expand All @@ -34,17 +33,12 @@ message RecordingMetadata {
bytes payload = 2;
}

message ObjectStorage {
string bucket_name = 1;
string url = 2;
}

message RegisterRecordingsResponse {
message RegisterRecordingResponse {
// Note / TODO(zehiko): this implies we read the record (for example go through entire .rrd file
// chunk by chunk) and extract the metadata. So we might want to 1/ not do this i.e.
// only do it as part of explicit GetMetadata request or 2/ do it if Request has "include_metadata=true"
// or 3/ do it always
repeated RecordingMetadata metadata = 2;
RecordingMetadata metadata = 2;
}

// Server can include details about the error as part of gRPC error (Status)
Expand Down
53 changes: 22 additions & 31 deletions crates/store/re_remote_store_types/src/v0/rerun.remote_store.v0.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading