Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC: Add protocol and comms implementation for FetchRecording #7909

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 25, 2024

What

This basically makes it possible to use the storage node as a proxy to fetch the full contents of all the chunks for the giving recording from the store.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added the do-not-merge Do not merge this PR label Oct 25, 2024
@jleibs jleibs force-pushed the jleibs/fetch_recording branch from 993565e to 465aa87 Compare October 29, 2024 14:07
@jleibs jleibs force-pushed the jleibs/fetch_recording branch from 465aa87 to dcdc237 Compare October 29, 2024 14:08
@jleibs jleibs added remote-store remote store gRPC API and removed do-not-merge Do not merge this PR labels Oct 29, 2024
@jleibs jleibs changed the title WIP: Add protocol and comms implementation for FetchRecording gRPC: Add protocol and comms implementation for FetchRecording Oct 29, 2024
@jleibs jleibs marked this pull request as ready for review October 29, 2024 14:16
@jleibs jleibs added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Oct 29, 2024
@jleibs jleibs merged commit 97e944b into main Oct 30, 2024
34 of 35 checks passed
@jleibs jleibs deleted the jleibs/fetch_recording branch October 30, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants