Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rr.serve -> rr.serve_web, rr.connect -> rr.connect_tcp #7906

Merged
merged 11 commits into from
Oct 28, 2024
Merged

rr.serve -> rr.serve_web, rr.connect -> rr.connect_tcp #7906

merged 11 commits into from
Oct 28, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 25, 2024 •
edited by github-actions bot
Loading

@teh-cmc teh-cmc added 🐍 Python API Python logging API 🦀 Rust API Rust logging API 🌊 C++ API C/C++ API specific include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Oct 25, 2024
@teh-cmc teh-cmc force-pushed the cmc/serve_connect_naming branch 2 times, most recently from 48878f6 to fa12aae Compare October 25, 2024 14:14
@rerun-io rerun-io deleted a comment from github-actions bot Oct 25, 2024
@rerun-io rerun-io deleted a comment from github-actions bot Oct 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Deployed docs

Commit Link
9fdcdc0 https://landing-mwz0f1scf-rerun.vercel.app/docs

@teh-cmc teh-cmc force-pushed the cmc/serve_connect_naming branch 3 times, most recently from b5df123 to 2bb47a9 Compare October 25, 2024 15:14
@teh-cmc teh-cmc marked this pull request as ready for review October 25, 2024 15:22
jleibs
jleibs approved these changes Oct 25, 2024
View reviewed changes
rerun_py/rerun_sdk/rerun/sinks.py Outdated Show resolved Hide resolved
@teh-cmc teh-cmc force-pushed the cmc/serve_connect_naming branch from 2bb47a9 to 5e9bdcc Compare October 28, 2024 08:19
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 28, 2024

I'm not quite sure what these errors mean:

mkdocs_autorefs: common/initialization_functions.md: from /home/runner/work/rerun/rerun/rerun_py/rerun_sdk/rerun/__init__.py:0: (rerun) Could not find cross-reference target 'rerun.connect_tcp'
mkdocs_autorefs: common/initialization_functions.md: from /home/runner/work/rerun/rerun/rerun_py/rerun_sdk/rerun/__init__.py:0: (rerun) Could not find cross-reference target 'rerun.serve_web'

and I'm not able to build the docs locally:

@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 28, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/11551100399

@teh-cmc teh-cmc merged commit 05d05bc into main Oct 28, 2024
66 of 68 checks passed
@teh-cmc teh-cmc deleted the cmc/serve_connect_naming branch October 28, 2024 09:39
@jleibs jleibs mentioned this pull request Nov 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zehiko zehiko zehiko approved these changes

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rr.serve should be rr.serve_websocket, rr.connect should be rr.connect_tcp
3 participants
@teh-cmc @jleibs @zehiko