Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix broken links #7889

Closed
wants to merge 5 commits into from
Closed

Docs: fix broken links #7889

wants to merge 5 commits into from

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 24, 2024 •
edited by github-actions bot
Loading

@teh-cmc teh-cmc added 🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

Deployed docs

Commit Link
cc94e54 https://landing-297vxok8o-rerun.vercel.app/docs

@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 24, 2024

Remaining failures are third-parties, all good.

@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 24, 2024

Now the question is: do we consider fixing the links good enough, or do we really want to maintain a million redirect stubs instead?

Wumpf
Wumpf approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's good enough for all pages here!

@teh-cmc teh-cmc marked this pull request as draft October 24, 2024 11:56
@teh-cmc teh-cmc marked this pull request as ready for review October 24, 2024 11:56
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 24, 2024

Change of plans: we'll fix the current batch of broken URLs with redirect stubs, and open an issue to decide how to handle these things in the future.

@teh-cmc teh-cmc closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf