Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributor CI #7879

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Fix contributor CI #7879

merged 8 commits into from
Oct 24, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 23, 2024

What

Note that this PR comes from a fork, which triggers contributor ci rather than maintainer ci.

Fixes various issues with the contributor ci which mostly come down to tooling problems.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 23, 2024
@Wumpf Wumpf force-pushed the andreas/fix-contributor-ci branch from c939682 to 0008f0e Compare October 24, 2024 08:45
@Wumpf Wumpf marked this pull request as ready for review October 24, 2024 11:28
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Most of that C++ stuff is over my head but I trust you :)

scripts/ci/build_and_upload_wheels.py Outdated Show resolved Hide resolved
@Wumpf Wumpf force-pushed the andreas/fix-contributor-ci branch from 58ea283 to 85673da Compare October 24, 2024 13:13
@Wumpf Wumpf merged commit 5770d58 into rerun-io:main Oct 24, 2024
32 checks passed
@Wumpf Wumpf deleted the andreas/fix-contributor-ci branch October 24, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants