Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column property accessors for selectors and descriptors #7752

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Add column property accessors for selectors and descriptors #7752

merged 3 commits into from
Oct 15, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 15, 2024 •
edited
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added feat-dataframe-api Everything related to the dataframe API 🐍 Python API Python logging API include in changelog labels Oct 15, 2024
@jleibs jleibs marked this pull request as ready for review October 15, 2024 16:13
@github-actions GitHub Actions
Copy link

Deployed docs

Commit Link
475ed5b https://landing-l8ie61j47-rerun.vercel.app/docs

Wumpf
Wumpf approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

don't quite get the bit in load_runtime_signatures, but looks sane, you surely know what you're doing ;-)

@jleibs jleibs merged commit 5425917 into main Oct 15, 2024
42 of 47 checks passed
@jleibs jleibs deleted the jleibs/column_props branch October 15, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
feat-dataframe-api Everything related to the dataframe API 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dataframe api] ComponentColumnDescriptor should expose component & entity name
3 participants
@jleibs @Wumpf @emilk