Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require nasm for AV1 decoding, unless on arm64 macOS #7742

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 15, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Oct 15, 2024
@emilk emilk added this to the 0.19 - Dataframe and video milestone Oct 15, 2024
@emilk
Copy link
Member Author

emilk commented Oct 15, 2024

@rerun-bot full-check

@emilk emilk marked this pull request as draft October 15, 2024 13:57
@emilk
Copy link
Member Author

emilk commented Oct 15, 2024

@rerun-bot full-check

Copy link

github-actions bot commented Oct 15, 2024

✅ Started a full build: https://github.com/rerun-io/rerun/actions/runs/11347670672

Comment on lines +16 to +18
/// Which features was this crate compiled with?
pub fn features() -> Vec<&'static str> {
// TODO(emilk): is there a helper crate for this?
Copy link
Member Author

@emilk emilk Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to do something smarter in a follow-up PR

@emilk emilk marked this pull request as ready for review October 15, 2024 14:24
@emilk emilk merged commit 6fb673b into main Oct 15, 2024
67 checks passed
@emilk emilk deleted the emilk/nasm-flag branch October 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
1 participant