-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require nasm for AV1 decoding, unless on arm64 macOS #7742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🧑💻 dev experience
developer experience (excluding CI)
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🎞️ video
labels
Oct 15, 2024
@rerun-bot full-check |
@rerun-bot full-check |
✅ Started a full build: https://github.com/rerun-io/rerun/actions/runs/11347670672 |
emilk
commented
Oct 15, 2024
Comment on lines
+16
to
+18
/// Which features was this crate compiled with? | ||
pub fn features() -> Vec<&'static str> { | ||
// TODO(emilk): is there a helper crate for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to do something smarter in a follow-up PR
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧑💻 dev experience
developer experience (excluding CI)
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🎞️ video
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
-F nasm
#7669nasm
feature on arch linux (for fasterrav1d
video decoding) #7671nasm
feature is turned onnasm
feature when building pre-built binariesrerun --version
to make testing of the above easyChecklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.