Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "filter is not null" in UI and code #7712

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Rename "filter is not null" in UI and code #7712

merged 1 commit into from
Oct 14, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Oct 14, 2024 •
edited
Loading

What

Rename "filter by event" to "filter is not null" everywhere in code + fix the copy in the dataframe view selection panel:

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-view Everything related to the dataframe view labels Oct 14, 2024
@github-actions GitHub Actions
Copy link

Deployed docs

Commit Link
f46cee8 https://landing-1lxiw52fl-rerun.vercel.app/docs

teh-cmc
teh-cmc reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta update re_chunk_store::QueryExpression too then

@abey79 abey79 merged commit 0e6a68d into main Oct 14, 2024
43 of 45 checks passed
@abey79 abey79 deleted the antoine/rename-filter-is-not-null branch October 14, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc left review comments

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-view Everything related to the dataframe view 🚜 refactor Change the code, not the functionality ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey79 @teh-cmc