Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe v2: no more encodings #7711

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Dataframe v2: no more encodings #7711

merged 2 commits into from
Oct 14, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 14, 2024

Removes JoinEncoding and all things related.

We'll bring that back in one form or another once we actually support it -- for now it just makes the public API more complex for no upside.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🚜 refactor Change the code, not the functionality include in changelog feat-dataframe-api Everything related to the dataframe API labels Oct 14, 2024
@teh-cmc teh-cmc merged commit 9d46fb1 into main Oct 14, 2024
34 checks passed
@teh-cmc teh-cmc deleted the cmc/dataframe_no_dict branch October 14, 2024 10:07
@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md and removed include in changelog labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md feat-dataframe-api Everything related to the dataframe API 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove public facing APIs that mention dictionary_encoding
2 participants