Document colorimetry aspects of video decoding, fix mixing up primaries & matrix coefficients #7707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Learned a lot more stuff recently which is now documented better.
Previously incorrectly called things out as color primaries when actually the difference is not the primaries (they are the same unless you go hairsplitting with PAL & NTSC), but the "Matrix Coefficients"
There's a small functional change in this pr - use dav1d's
matrix_coefficients
instead ofcolor_primaries
- but since we're very likely to still almost always choose Bt709 coefficients I expect this to be a very very minor change in practice.Meaning to say the meat of this is the docs & renames ;-)
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.