Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document colorimetry aspects of video decoding, fix mixing up primaries & matrix coefficients #7707

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 12, 2024

What

Learned a lot more stuff recently which is now documented better.
Previously incorrectly called things out as color primaries when actually the difference is not the primaries (they are the same unless you go hairsplitting with PAL & NTSC), but the "Matrix Coefficients"

There's a small functional change in this pr - use dav1d's matrix_coefficients instead of color_primaries - but since we're very likely to still almost always choose Bt709 coefficients I expect this to be a very very minor change in practice.

Meaning to say the meat of this is the docs & renames ;-)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Oct 12, 2024
//!
//! We'll very likely be good with this until either we get specific feature requests and/or we'll start
//! supporting HDR content at which point more properties will be important!
//!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 🙏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or horrible, depending how you look at it 😄

@Wumpf Wumpf merged commit e845174 into main Oct 14, 2024
35 of 36 checks passed
@Wumpf Wumpf deleted the andreas/fix-language-around-yuv-conversions branch October 14, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality 🎞️ video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants