Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log_static() for constant data in DNA example. #7701

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

kpreid
Copy link
Collaborator

@kpreid kpreid commented Oct 11, 2024

What

Just a tiny little thing that was bugging me: the DNA example now uses log_static() for all the non-animated data logged at the beginning. This gives better results when viewing with a time range query — otherwise the left, right, and scaffolding always disappear if the time range doesn’t include the beginning of the recording.

Here is the new appearance with a 0.5 second time range; previously, only the gray points would be visible:

Screenshot

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

This gives better results when viewing with a time range query.
@kpreid kpreid added examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 11, 2024
@kpreid kpreid marked this pull request as ready for review October 11, 2024 22:27
@teh-cmc
Copy link
Member

teh-cmc commented Oct 12, 2024

Nice -- I've been meaning to do that for a while.

log_static is deprecated though, lemme fix that. Oh wait this the Rust example.

Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want it too. But if we do it we need to do it on all three DNA examples (python, cpp, rust)!

@teh-cmc teh-cmc marked this pull request as draft October 23, 2024 07:05
@teh-cmc
Copy link
Member

teh-cmc commented Oct 23, 2024

(marking as draft to relax the review queue til then)

@Wumpf
Copy link
Member

Wumpf commented Nov 15, 2024

taking this over, I too want this too :)

@Wumpf Wumpf self-assigned this Nov 15, 2024
@Wumpf
Copy link
Member

Wumpf commented Nov 15, 2024

✅ tested C++ & Python manually (you never know, weirder things have broken...)

@Wumpf Wumpf requested a review from teh-cmc November 15, 2024 09:50
@Wumpf Wumpf marked this pull request as ready for review November 15, 2024 09:50
@Wumpf
Copy link
Member

Wumpf commented Nov 15, 2024

ci:

  • known rust failure, fix is up
  • C++ runner running out of space. okay. 🤦

@Wumpf Wumpf merged commit bb092e5 into rerun-io:main Nov 15, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants