-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use log_static()
for constant data in DNA example.
#7701
Conversation
This gives better results when viewing with a time range query.
Nice -- I've been meaning to do that for a while.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want it too. But if we do it we need to do it on all three DNA examples (python, cpp, rust)!
(marking as draft to relax the review queue til then) |
taking this over, I too want this too :) |
✅ tested C++ & Python manually (you never know, weirder things have broken...) |
ci:
|
What
Just a tiny little thing that was bugging me: the DNA example now uses
log_static()
for all the non-animated data logged at the beginning. This gives better results when viewing with a time range query — otherwise theleft
,right
, andscaffolding
always disappear if the time range doesn’t include the beginning of the recording.Here is the new appearance with a 0.5 second time range; previously, only the gray points would be visible:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.