-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow component selectors to be specified as strings with flexible matching #7695
Conversation
@@ -793,13 +794,36 @@ impl ChunkStore { | |||
&self, | |||
selector: &ComponentColumnSelector, | |||
) -> ComponentColumnDescriptor { | |||
// Happy path if this string is a valid component | |||
let direct_component = ComponentName::from(selector.component_name.clone()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I guess that means we're going to intern a bunch of random strings indefinitely.
This is hardly a problem in practice, but might deserve a NOTE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: #7699
What
This means you can now do:
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.