Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that Rerun does not support left-handed coords #7690

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 11, 2024

What

Screenshot 2024-10-11 at 11 27 56 Screenshot 2024-10-11 at 11 25 48

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 📖 documentation Improvements or additions to documentation include in changelog labels Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

Deployed docs

Commit Link
55fb465 https://landing-2n7nzf7n0-rerun.vercel.app/docs

@Wumpf Wumpf self-requested a review October 11, 2024 09:34
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +55 to +62
deterimnant = (
m00 * m11 * m22 + m01 * m12 * m20 + m02 * m10 * m21 - m02 * m11 * m20 - m01 * m10 * m22 - m00 * m12 * m21
)

if deterimnant == 1:
return False
elif deterimnant == -1:
return True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels brutal but effective, I like it 😄

@emilk emilk merged commit c06745f into main Oct 11, 2024
40 checks passed
@emilk emilk deleted the emilk/document-left-handedness branch October 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document lack of left-handed coordinate support
2 participants