-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NumPy arrays to the arrow serializer for string datatypes #7689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit test plz!
also this could be fairly easy part of codegen? Something seems to be wrong with codegen here
Utf8
datatype arrow serializer9d7a0d8
to
bb3f99f
Compare
bb3f99f
to
487e557
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
annotation only change now huh? But very nice to solve this once and for all via codegen :)
What
This adds support for Numpy array for batches of
Utf8
datatypes. For example, this facilitates logging aTextBatch
when using Pandas dataframe:Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.